[PATCH] D67026: Introduce a DirectoryEntryRef that stores both a reference and an accessed name to the directory entry

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 30 18:26:41 PDT 2019


arphaman marked 4 inline comments as done.
arphaman added inline comments.


================
Comment at: clang/lib/Lex/HeaderSearch.cpp:299
 StringRef DirectoryLookup::getName() const {
+  // FIXME: Use the name from \c DirectoryEntryRef.
   if (isNormalDir())
----------------
dexonsmith wrote:
> Did you mean to leave this behind for a future commit?  Or did you miss fixing this?
This is for a future commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67026/new/

https://reviews.llvm.org/D67026





More information about the cfe-commits mailing list