[PATCH] D67023: Diagnose use of ATOMIC_VAR_INIT
Richard Smith - zygoloid via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Aug 30 15:40:49 PDT 2019
rsmith added inline comments.
================
Comment at: lib/Lex/PPMacroExpansion.cpp:523
+ llvm::sys::path::filename(getSourceManager().getFilename(
+ M.getLocalDirective()->getLocation())) == "stdatomic.h") {
+ Diag(Identifier, diag::warn_pp_macro_deprecated)
----------------
This assumes there is a local directive for the macro. There need not be (it could be imported from a module). We should presumably check to see if all active macro directives are from that header instead.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67023/new/
https://reviews.llvm.org/D67023
More information about the cfe-commits
mailing list