[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature
Diogo N. Sampaio via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Aug 30 08:46:49 PDT 2019
dnsampaio requested changes to this revision.
dnsampaio added a comment.
This revision now requires changes to proceed.
`clang -### -target arm-arm-none-eabit -march=armv8-m.main+crypto` did not show +sha2 or +aes. After the patch it does.
I believe that is not expected, as in ARM.td `crypto` is not applied for any M profile. And ArmĀ®v8-M Architecture Reference Manual does not reference these extensions neither.
================
Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:485
+
+ if (llvm::ARM::parseArchVersion(ArchSuffix) >= 8) {
+ auto CryptoIt =
----------------
` && (llvm::ARM::parseArchProfile(Arch) == llvm::ARM::ProfileKind::A)`
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66018/new/
https://reviews.llvm.org/D66018
More information about the cfe-commits
mailing list