[PATCH] D66738: [clangd] Added highlighting for structured bindings.

[Haojian Wu via Phabricator via cfe-commits]

hokein added a comment.

I don't have a strong preference on how to highlight `BindingDecl`, but I think highlighting them as `Variable` is better than no highlighting them at all, so LGTM from myside. @ilya-biryukov thoughts?

again, please update the patch description in phabricator and your git commit message.



================
Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp:443
+        $Primitive[[int]] $Variable[[A]][2] = {1,2};
+        auto [$Variable[[B1]], $Variable[[B2]]] = $Variable[[A]];
+        auto [$Variable[[G1]], $Variable[[G2]]] = $Variable[[Global]];
----------------
this is not related to the patch,  but the highlighting behavior for auto here is weird, some of them are highlighted while some of them are not. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66738/new/

https://reviews.llvm.org/D66738