[PATCH] D66990: [clangd] Add distinct highlightings for declarations of functions and methods

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added a comment.

In D66990#1652172 <https://reviews.llvm.org/D66990#1652172>, @jvikstrom wrote:

> Should we have different highlightings for declarations vs usages? (Although I guess in the end it will be up to the editor if they highlight them differently as the scope is just more specific for declarations)
>  I guess I personally don't really see the reason as it should be clear from the context if it's a declaration or a function call.


I also second the opinion that usages and declarations should be highlighted the same.
Both represent the **same** thing, therefore they should have the **same** color.

And this highlighting does not seem to add any extra information too - it's obvious from the code whether a name is a declaration or a usage.
Even in the macro cases, the users usually know the semantics of the macro or can infer from the name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66990/new/

https://reviews.llvm.org/D66990