[PATCH] D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU
Richard Smith - zygoloid via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Aug 29 16:04:26 PDT 2019
rsmith added a comment.
In D64799#1608085 <https://reviews.llvm.org/D64799#1608085>, @ilya-biryukov wrote:
> @rsmith two options for this patch seem to be:
>
> - silently ignore the errors (behavior before this patch),
> - show them to the user at the end of TU (what happens in the current version of the patch). This can result in bad UX, but we won't drop any errors on the floor. Which one do you think we should prefer?
Let's take the second option. It seems better to diagnose an error late than not at all.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64799/new/
https://reviews.llvm.org/D64799
More information about the cfe-commits
mailing list