[PATCH] D64874: [Sema] Improve handling of function pointer conversions

[Richard Smith - zygoloid via Phabricator via cfe-commits]

rsmith added inline comments.


================
Comment at: clang/lib/Sema/SemaTemplate.cpp:6996
+      // a noexcept function can be converted to a noexcept(false) function.
+      QualType resultTy;
+      if (getLangOpts().CPlusPlus17 &&
----------------
Please capitalize local variable names to match the local convention.


================
Comment at: clang/test/CXX/conv/conv.fctptr/template-noexcept-invalid.cpp:8
+// a noexcept function can be converted to a noexcept(false) function.
+// The tests were added for https://bugs.llvm.org/show_bug.cgi?id=40024
+// Tests the no longer valid function pointer conversions
----------------
You can just say PR40024 instead of spelling out the complete URL. That'll also work better if we migrate our bug tracker to a different system one day. (Incidentally, llvm.org/PR40024 works too.)


================
Comment at: clang/test/CXX/conv/conv.fctptr/template-noexcept-invalid.cpp:22
+
+// CHECK: error: no matching function for call to 'f10'
----------------
Please use a `-verify` test for this instead of `FileCheck`, and combine the `-valid` and `-invalid` testcases into the same test file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64874/new/

https://reviews.llvm.org/D64874