[PATCH] D66710: ASTReader: Bypass overridden files when reading PCHs

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 28 18:33:17 PDT 2019


dexonsmith marked 2 inline comments as done.
dexonsmith added inline comments.


================
Comment at: clang/include/clang/Basic/FileManager.h:320
+  /// twice, you get two new file entries.
+  const FileEntry *getBypassFile(const FileEntry &VFE);
+
----------------
bruno wrote:
> Does it make sense to return/read from a FileEntryRef here? @arphaman, wdyt?
SGTM.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66710/new/

https://reviews.llvm.org/D66710





More information about the cfe-commits mailing list