[PATCH] D66710: ASTReader: Bypass overridden files when reading PCHs

Bruno Cardoso Lopes via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 28 16:57:26 PDT 2019


bruno added a comment.

Nice! Is this something that can be tested for in `unittests/Basic/FileManagerTest.cpp`?



================
Comment at: clang/include/clang/Basic/FileManager.h:320
+  /// twice, you get two new file entries.
+  const FileEntry *getBypassFile(const FileEntry &VFE);
+
----------------
Does it make sense to return/read from a FileEntryRef here? @arphaman, wdyt?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66710/new/

https://reviews.llvm.org/D66710





More information about the cfe-commits mailing list