[PATCH] D66881: [clangd][vscode] Don't leak the resources
Haojian Wu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 28 08:03:24 PDT 2019
hokein added a comment.
In D66881#1649044 <https://reviews.llvm.org/D66881#1649044>, @jvikstrom wrote:
> Oh, was not aware we needed to dispose the extension as well.
>
> I think you should probably add the SemanticHighlightingFeature to the context.subscriptions as well, right? (because I didn't when I did the cleanup patch for it, sorry)
good catch, done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66881/new/
https://reviews.llvm.org/D66881
More information about the cfe-commits
mailing list