[PATCH] D66866: [ASTImporter] At import of records re-order indirect fields too.

[Gabor Marton via Phabricator via cfe-commits]

martong added a comment.

Looks good, I just have a comment about the matcher.



================
Comment at: clang/unittests/AST/ASTImporterTest.cpp:1434
 
+AST_MATCHER_P(RecordDecl, hasFieldIndirectFieldOrder, std::vector<StringRef>,
+              Order) {
----------------
This name sounds strange for me, perhaps `hasAnyKindOfFieldOrder` ?
Also, this matcher I think supersedes the `hasFieldOrder`, I mean in the tests where we use `hasFieldOrder` we could use this new matcher too, can't we? In that case, however, we can delete the old implementation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66866/new/

https://reviews.llvm.org/D66866