[PATCH] D66869: [clangd] Fix SelectionTree to allow selection range expression in foreach loops.
Haojian Wu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 28 04:56:25 PDT 2019
hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/unittests/SelectionTests.cpp:275
+ void loop() {
+ for (const char* C : [[mak^eStr("f^oo")]])
+ ;
----------------
nit: the ^ inside the string "foo" is a bit tricky, I didn't spot it at the first glance, I'd move it out of the string, e.g. `mak^eStr("foo"^)`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66869/new/
https://reviews.llvm.org/D66869
More information about the cfe-commits
mailing list