[PATCH] D66839: Fix stack address builtin for negative numbers

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 27 17:01:35 PDT 2019


efriedma added a comment.

We usually prefer to generate error messages for incorrect parameters to builtins in SemaChecking.cpp.

I don't think there's really an infinite loop here.  The parameter to __builtin_frame_address is an unsigned integer; values greater than 0x7FFFFFFU aren't special.  The reason it takes a very long time is that we try to unroll the implied loop; generating an object file with four billion load instructions takes essentially forever.  We could impose a smaller limit, but it would be sort of arbitrary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66839/new/

https://reviews.llvm.org/D66839





More information about the cfe-commits mailing list