[PATCH] D66598: [Clang][Bundler] Fix for a hang when unbundling fat binary
Sergey Dmitriev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Aug 27 13:51:35 PDT 2019
sdmitriev marked an inline comment as done.
sdmitriev added inline comments.
================
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:295
return StringRef();
-
+ CurBundleInfo = NextBundleInfo++;
return CurBundleInfo->first();
----------------
ABataev wrote:
> Maybe just:
> ```
> const BundleInfo &Bundle = *CurBundleInfo;
> std::advance(CurBundleInfo, 1);
> return Bundle.first();
> ```
> instead of all these changes?
It could be done like this if CurBundleInfo was not used in ReadBundle.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66598/new/
https://reviews.llvm.org/D66598
More information about the cfe-commits
mailing list