[PATCH] D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction

Tue Aug 27 13:14:55 PDT 2019

Szelethus added a comment.

In D66716#1647668 <https://reviews.llvm.org/D66716#1647668>, @NoQ wrote:

> I don't understand. Isn't widening supposed to happen //after we exit the loop//? The loop isn't over yet when the bug is being reported. Why is this problem widening-specific? Given that we also have a weird invalidation of `b`, i suspect that we're doing widening in a wrong moment of time.

Something is totally off here. Do you think its ever okay to find a last store in a `BlockEdge`? Should I rather fix this by changing how loop widening works?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66716/new/

https://reviews.llvm.org/D66716