[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

[Paul Kirth via Phabricator via cfe-commits]

paulkirth marked 6 inline comments as done.
paulkirth added inline comments.


================
Comment at: llvm/include/llvm/IR/DiagnosticInfo.h:1009
+public:
+  DiagnosticInfoMisExpect(const Function &Fn, const Twine &Msg,
+                          const DiagnosticLocation &Loc = DiagnosticLocation(),
----------------
nickdesaulniers wrote:
> Is this constructor used anywhere in this patch?
No, sorry, I changed this interface and failed to remove the constructor.


================
Comment at: llvm/lib/IR/DiagnosticInfo.cpp:378
+                                     Inst->getDebugLoc()),
+      Msg(Msg) {}
+
----------------
nickdesaulniers wrote:
> Why is this constructor defined out of line, when the other is in the header?  Seems like they should either both be in the header, or both be out of line, with the goal being consistency.
I removed the other constructor, which was unused. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66324/new/

https://reviews.llvm.org/D66324