[PATCH] D66813: Remove clang-tidy-vs plugin from clang-tools-extra
Alex Lorenz via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Aug 27 11:01:19 PDT 2019
arphaman created this revision.
arphaman added a reviewer: rnk.
Herald added subscribers: ributzka, dexonsmith, jkorous, mgorny.
Herald added a project: clang.
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
The `clang-tidy-vs` visual studio plugin in clang-tools-extra contains a
security vulnerability in the YamlDotNet package [1]. I posted to cfe-dev [2],
asking if there was anyone who was interested in updating the the plugin
to address the vulnerability. Reid mentioned that Zach (the original committer),
said that there's another plugin (Clang Power Tools) that provides clang-tidy support,
with additional extra features, so it would be ok to remove clang-tidy-vs.
This patch removes the plugin to address the security vulnerability, and adds
a section to the release notes that mentions that the plugin was removed, and
suggests to use Clang Power Tools.
[1]: https://nvd.nist.gov/vuln/detail/CVE-2018-1000210
[2]: http://lists.llvm.org/pipermail/cfe-dev/2019-August/063196.html
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D66813
Files:
clang-tools-extra/CMakeLists.txt
clang-tools-extra/clang-tidy-vs/.gitignore
clang-tools-extra/clang-tidy-vs/CMakeLists.txt
clang-tools-extra/clang-tidy-vs/ClangTidy.sln
clang-tools-extra/clang-tidy-vs/ClangTidy/CategoryVerb.cs
clang-tools-extra/clang-tidy-vs/ClangTidy/CheckDatabase.cs
clang-tools-extra/clang-tidy-vs/ClangTidy/CheckTree.cs
clang-tools-extra/clang-tidy-vs/ClangTidy/ClangTidy.csproj
clang-tools-extra/clang-tidy-vs/ClangTidy/ClangTidy.vsct
clang-tools-extra/clang-tidy-vs/ClangTidy/ClangTidyCheckAttribute.cs
clang-tools-extra/clang-tidy-vs/ClangTidy/ClangTidyConfigParser.cs
clang-tools-extra/clang-tidy-vs/ClangTidy/ClangTidyConfigurationPage.cs
clang-tools-extra/clang-tidy-vs/ClangTidy/ClangTidyPackage.cs
clang-tools-extra/clang-tidy-vs/ClangTidy/ClangTidyProperties.cs
clang-tools-extra/clang-tidy-vs/ClangTidy/ClangTidyPropertyGrid.Designer.cs
clang-tools-extra/clang-tidy-vs/ClangTidy/ClangTidyPropertyGrid.cs
clang-tools-extra/clang-tidy-vs/ClangTidy/ClangTidyPropertyGrid.resx
clang-tools-extra/clang-tidy-vs/ClangTidy/DynamicPropertyComponent.Designer.cs
clang-tools-extra/clang-tidy-vs/ClangTidy/DynamicPropertyComponent.cs
clang-tools-extra/clang-tidy-vs/ClangTidy/DynamicPropertyConverter.cs
clang-tools-extra/clang-tidy-vs/ClangTidy/DynamicPropertyDescriptor.cs
clang-tools-extra/clang-tidy-vs/ClangTidy/ForwardingPropertyDescriptor.cs
clang-tools-extra/clang-tidy-vs/ClangTidy/GlobalSuppressions.cs
clang-tools-extra/clang-tidy-vs/ClangTidy/Guids.cs
clang-tools-extra/clang-tidy-vs/ClangTidy/PkgCmdID.cs
clang-tools-extra/clang-tidy-vs/ClangTidy/Properties/AssemblyInfo.cs
clang-tools-extra/clang-tidy-vs/ClangTidy/Resources.Designer.cs
clang-tools-extra/clang-tidy-vs/ClangTidy/Resources.resx
clang-tools-extra/clang-tidy-vs/ClangTidy/Resources/ClangTidyChecks.yaml
clang-tools-extra/clang-tidy-vs/ClangTidy/Resources/Images_32bit.bmp
clang-tools-extra/clang-tidy-vs/ClangTidy/Resources/Package.ico
clang-tools-extra/clang-tidy-vs/ClangTidy/Utility.cs
clang-tools-extra/clang-tidy-vs/ClangTidy/VSPackage.resx
clang-tools-extra/clang-tidy-vs/ClangTidy/license.txt
clang-tools-extra/clang-tidy-vs/ClangTidy/packages.config
clang-tools-extra/clang-tidy-vs/ClangTidy/source.extension.vsixmanifest
clang-tools-extra/clang-tidy-vs/README.txt
clang-tools-extra/clang-tidy-vs/source.extension.vsixmanifest.in
clang-tools-extra/docs/ReleaseNotes.rst
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66813.217434.patch
Type: text/x-patch
Size: 156802 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190827/084f189f/attachment-0001.bin>
More information about the cfe-commits
mailing list