[PATCH] D66743: [clangd] Cleans up the semantic highlighting resources if clangd crashes.

[Johan Vikström via Phabricator via cfe-commits]

jvikstrom marked 2 inline comments as done.
jvikstrom added inline comments.


================
Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:114
+  // restarts.
+  public crashDispose() {
+    this.disposables.forEach((d) => d.dispose());
----------------
hokein wrote:
> we just dispose some class members (leading the class to an intermediate state), I'd suggest that we dispose the whole class.
> 
> nit: please remove the "clangd crashes" bit in the API.
The only thing remaining to dispose is the highlighter. Should we remove all highlightings if clangd restarts?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66743/new/

https://reviews.llvm.org/D66743