[PATCH] D66759: [clangd] Surface errors from command-line parsing

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added a comment.

Thanks! This looks really useful when we can't build an AST due to unknown compiler commands, but I am not sure about how useful it is to surface command-line parsing errors once we are able to build an AST.
Because people most likely won't care about these errors once clangd is working for them, and even get annoyed since most of the developers has little control over how their build system generates their compile
commands, therefore it will be really hard to get rid of those errors showing up in all the files they want to edit.

So I suggest only surfacing these if we are not able to create a compiler invocation or build an ast at all. WDYT?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66759/new/

https://reviews.llvm.org/D66759