[PATCH] D66788: Refactor GlobList from an ad-hoc linked list to a vector
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Aug 27 01:33:34 PDT 2019
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: clang-tools-extra/clang-tidy/GlobList.cpp:46
+GlobList::GlobList(StringRef Globs) {
+ do {
+ GlobListItem Item;
----------------
NIT: I suggest using `for (;!Globs.empty();) {}` to make the stop condition stand out more.
Not a big deal, though, feel free to keep as is
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66788/new/
https://reviews.llvm.org/D66788
More information about the cfe-commits
mailing list