[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

[Alexey Bataev via Phabricator via cfe-commits]

ABataev added inline comments.


================
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:888
+  // treat missing host triple as error if we do unbundling.
+  if ((Unbundle && HostTargetNum > 1) || (!Unbundle && HostTargetNum != 1)) {
     Error = true;
----------------
sdmitriev wrote:
> ABataev wrote:
> > I believe,  for unbundling we also must check for `!= 1` rather than `> 1`. Zero host targets also is not allowed.
> But the whole idea of this change is to remove requirement to provide host triple for unbundling operation. Target bundle(s) can always be extracted without extracting host, so host bundle is optional. Therefore zero host targets should not be considered as error for unbundling.
And why do we need this? I think it would be better to check that the requested host triple matches the bundled one using this parameter rather than removing it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66601/new/

https://reviews.llvm.org/D66601