[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles
Alexey Bataev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 26 14:09:16 PDT 2019
ABataev added inline comments.
================
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:888
+ // treat missing host triple as error if we do unbundling.
+ if ((Unbundle && HostTargetNum > 1) || (!Unbundle && HostTargetNum != 1)) {
Error = true;
----------------
I believe, for unbundling we also must check for `!= 1` rather than `> 1`. Zero host targets also is not allowed.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66601/new/
https://reviews.llvm.org/D66601
More information about the cfe-commits
mailing list