[PATCH] D66731: [Driver] Add an option for createInvocationFromCommandLine to recover on errors

Mon Aug 26 11:05:14 PDT 2019

ilya-biryukov added a comment.

In D66731#1644840 <https://reviews.llvm.org/D66731#1644840>, @gribozavr wrote:

> - In the doc comment for `CompilerInvocation::CreateFromArgs`, could you add a note that it does a best effort to provide a CompilerInvocation even if it returns false? Right now the doc comment reads like there are no guarantees at all if it returns false.

Will do and update this patch.

> - (can be a separate patch) Could we produce a diagnostic in the affected TU notifying the user that the compiler commands could not be parsed and we did our best to recover, but it may be completely wrong?

You are right, this is long overdue. Although not specific to this particular patch, which aims at options for better recovery rather than fixing this limitation of clangd.
Nevertheless, D66759 <https://reviews.llvm.org/D66759> surfaces the errors from command-line arguments in clangd and should address this point as well.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66731/new/

https://reviews.llvm.org/D66731