[PATCH] D66695: msan, codegen, instcombine: Keep more lifetime markers used for msan

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 26 11:05:13 PDT 2019


lebedev.ri added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/lifetime-sanitizer.ll:37-50
+define void @msan() sanitize_memory {
+entry:
+  ; CHECK-LABEL: @msan(
+  %text = alloca i8, align 1
+
+  call void @llvm.lifetime.start.p0i8(i64 1, i8* %text)
+  call void @llvm.lifetime.end.p0i8(i64 1, i8* %text)
----------------
eugenis wrote:
> lebedev.ri wrote:
> > Would be good to have end-to-end test (`-O0`/`-O1`/`-O2`/`-O3`) in PhaseOrdering.
> Do you mean exact same test, but with -O0/../-O3 instead of -instcombine?
Yes, but please put it into PhaseOrdering directory,


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66695/new/

https://reviews.llvm.org/D66695





More information about the cfe-commits mailing list