[PATCH] D66627: [clang-tidy] new check: bugprone-pthread-return

[Jian Cai via Phabricator via cfe-commits]

jcai19 marked an inline comment as done.
jcai19 added a comment.

In D66627#1644775 <https://reviews.llvm.org/D66627#1644775>, @gribozavr wrote:

> Thanks for the contribution! In abstract, I think it is a good checker, however, the implementation largely duplicates `clang-tidy/bugprone/PosixReturnCheck.cpp` -- do you think you could factor out the common parts? I see at least two ways:
>
> - Factor out a library, use it in both checkers.
> - Put everything into one checker, if necessary, add configuration options to turn on/off POSIX and PThread parts. However, I don't even think configuration options would be necessary -- it is unlikely that someone would want one but not the other -- or is there a use case?


That's a good suggestion. I will try to combine it with POSIX check. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66627/new/

https://reviews.llvm.org/D66627