[PATCH] D66733: [analyzer] Add a checker option to detect nested dead stores

Mon Aug 26 08:47:46 PDT 2019

steakhal added a comment.

@NoQ What do you think, should it be under a flag (as it would be now), or enabled by default?
I think these warnings are valuable and we should consider it enabling by default.
An interesting fact is that previously rGf224820b45c6847b91071da8d7ade59f373b96f3 <https://reviews.llvm.org/rGf224820b45c6847b91071da8d7ade59f373b96f3> patch disabled this warning saying that it generates too many false-positives without any real benefit.

But after seeing the reports on the LLVM codebase (CodeChecker instance for the diff <http://cc.elte.hu:15200/Default/#run=before%20deadstore%20option&newcheck=after%20deadstore%20option&review-status=Unreviewed&review-status=Confirmed&detection-status=New&detection-status=Reopened&detection-status=Unresolved&tab=before%20deadstore%20option_diff_after%20deadstore%20option>) I still question this decision. What is your opinion?

Any comment how could this result in false-positives are welcomed.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66733/new/

https://reviews.llvm.org/D66733