[PATCH] D66538: [AST] AST structural equivalence to work internally with pairs.

[Gabor Marton via Phabricator via cfe-commits]

martong added a comment.

In D66538#1642999 <https://reviews.llvm.org/D66538#1642999>, @balazske wrote:

> In D66538#1642883 <https://reviews.llvm.org/D66538#1642883>, @martong wrote:
>
> > There is a third test which could be useful to test whether there is no faulty cache entries there:
> >
> >   +TEST_F(StructuralEquivalenceCacheTest, DISABLED_NonEq) {
> >   ...
> >   +}
> >
>
>
> This is somewhat the same check that is done in the current tests when the `NonEquivalentDecls` is checked to not contain any pairs of equivalent Decls. (Specially this line:
>
>   EXPECT_FALSE(isInNonEqCache(
>         findDeclPair<FunctionDecl>(TU, functionDecl(hasName("x")))));
>
>
> )


Ok, that looks good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66538/new/

https://reviews.llvm.org/D66538