[PATCH] D66723: [clangd] Add a distinct highlighting for local variables

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 26 01:27:48 PDT 2019


hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/SemanticHighlighting.h:38
   Primitive,
+  LocalVariable,
 
----------------
ilya-biryukov wrote:
> NIT: maybe put it right after `Variable`? IIUC, we do not rely on actual numeric values being the same across different clangd versions.
+1, related symbols should be grouped together.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66723/new/

https://reviews.llvm.org/D66723





More information about the cfe-commits mailing list