[PATCH] D66511: [clang-scan-deps] Skip UTF-8 BOM in source minimizer
Alexandre Ganea via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sat Aug 24 10:30:00 PDT 2019
aganea marked an inline comment as done.
aganea added inline comments.
================
Comment at: lib/Lex/DependencyDirectivesSourceMinimizer.cpp:822
bool Minimizer::minimizeImpl(const char *First, const char *const End) {
+ skipUTF8ByteOrderMark(First, End);
while (First != End)
----------------
dexonsmith wrote:
> Is skipping this the right thing, or should it also be copied to the output?
The code in `Lexer::InitLexer()` assumes the files are always encoded as UTF-8, it simply skips over the BOM like we do here.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66511/new/
https://reviews.llvm.org/D66511
More information about the cfe-commits
mailing list