[PATCH] D65526: [Clangd] First version of ExtractFunction

Shaurya Gupta via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 23 06:07:15 PDT 2019


SureYeaah marked an inline comment as done.
SureYeaah added inline comments.


================
Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:360
+
+CapturedSourceInfo::DeclInformation &
+CapturedSourceInfo::getDeclInformationFor(const Decl *D) {
----------------
SureYeaah wrote:
> kadircet wrote:
> > why not move this and 4 following functions into astvisitor?
> Because we would need to pass CapturedSourceInfo and ExtractionZone to the Visitor then?
Ignore.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65526/new/

https://reviews.llvm.org/D65526





More information about the cfe-commits mailing list