[PATCH] D66593: [analyzer] CastValueChecker: Fix some assertions

Csaba Dabis via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 23 01:00:35 PDT 2019


Charusso added a comment.

In D66593#1642253 <https://reviews.llvm.org/D66593#1642253>, @Charusso wrote:

> Wow, it is great you could address every of the edge cases. Thanks you so much! I believe only one problem left: we need to `return false` instead of plain `return` in order to let the Analyzer model the function call. I could fix it easily, thanks!


Well, not really. I have tested out and there is no difference. Thanks for the fixes!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66593/new/

https://reviews.llvm.org/D66593





More information about the cfe-commits mailing list