[PATCH] D66627: [clang-tidy] new check: bugprone-pthread-return

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/bugprone/PthreadReturnCheck.cpp:1
+//===--- PthreadReturnCheck.cpp -
+//clang-tidy---------------------------------===//
----------------
Please make it single line, 80 characters long.


================
Comment at: clang-tools-extra/clang-tidy/bugprone/PthreadReturnCheck.cpp:23
+                                     const char *BindingStr) {
+  const CallExpr *MatchedCall = cast<CallExpr>(
+      (Result.Nodes.getNodeAs<BinaryOperator>(BindingStr))->getLHS());
----------------
You could use const auto * here, because type is spelled in same statement.


================
Comment at: clang-tools-extra/clang-tidy/bugprone/PthreadReturnCheck.h:1
+//===--- PthreadReturnCheck.h - clang-tidy-------------------------*- C++ -*-===//
+//
----------------
Please make line 80 characters long.


================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:82
 
+- New :doc:`bugprone-pthread-return
+  <clang-tidy/checks/bugprone-pthread-return>` check.
----------------
Please keep new checks list sorted alphabetically.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66627/new/

https://reviews.llvm.org/D66627