[PATCH] D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467)

[Roman Lebedev via Phabricator via cfe-commits]

lebedev.ri requested changes to this revision.
lebedev.ri added a comment.
This revision now requires changes to proceed.

Please can you explain why the snippet i posted in-line does not work for you?



================
Comment at: clang/lib/Sema/SemaChecking.cpp:8105-8107
+          if (ImplicitMatch == analyze_printf::ArgType::NoMatchPedantic)
+            Pedantic = true;
           return true;
----------------
I do not understand this.
Even if you set `Pedantic = true`, you will immediately `return true` without ever using that `Pedantic`.
This seems broken?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66186/new/

https://reviews.llvm.org/D66186