[PATCH] D66492: [Clang][CodeGen] set alias linkage on QualType

[Leonard Chan via Phabricator via cfe-commits]

leonardchan added a comment.

I think this patch might be causing some test failures on our mac bots:

  FAIL: Clang :: CodeGen/alias.c (2014 of 15397)
  ******************** TEST 'Clang :: CodeGen/alias.c' FAILED ********************
  Script:
  --
  : 'RUN: at line 2';   /b/s/w/ir/k/recipe_cleanup/clangVieak_/llvm_build_dir/bin/clang -cc1 -internal-isystem /b/s/w/ir/k/recipe_cleanup/clangVieak_/llvm_build_dir/lib/clang/10.0.0/include -nostdsysteminc -triple i386-pc-linux-gnu -emit-llvm -o - /b/s/w/ir/k/llvm-project/clang/test/CodeGen/alias.c | /b/s/w/ir/k/recipe_cleanup/clangVieak_/llvm_build_dir/bin/FileCheck -check-prefix=CHECKBASIC /b/s/w/ir/k/llvm-project/clang/test/CodeGen/alias.c
  : 'RUN: at line 3';   /b/s/w/ir/k/recipe_cleanup/clangVieak_/llvm_build_dir/bin/clang -cc1 -internal-isystem /b/s/w/ir/k/recipe_cleanup/clangVieak_/llvm_build_dir/lib/clang/10.0.0/include -nostdsysteminc -triple armv7a-eabi -mfloat-abi hard -emit-llvm -o - /b/s/w/ir/k/llvm-project/clang/test/CodeGen/alias.c | /b/s/w/ir/k/recipe_cleanup/clangVieak_/llvm_build_dir/bin/FileCheck -check-prefix=CHECKCC /b/s/w/ir/k/llvm-project/clang/test/CodeGen/alias.c
  : 'RUN: at line 4';   /b/s/w/ir/k/recipe_cleanup/clangVieak_/llvm_build_dir/bin/clang -cc1 -internal-isystem /b/s/w/ir/k/recipe_cleanup/clangVieak_/llvm_build_dir/lib/clang/10.0.0/include -nostdsysteminc -triple armv7a-eabi -mfloat-abi hard -S -o - /b/s/w/ir/k/llvm-project/clang/test/CodeGen/alias.c | /b/s/w/ir/k/recipe_cleanup/clangVieak_/llvm_build_dir/bin/FileCheck -check-prefix=CHECKASM /b/s/w/ir/k/llvm-project/clang/test/CodeGen/alias.c
  : 'RUN: at line 5';   /b/s/w/ir/k/recipe_cleanup/clangVieak_/llvm_build_dir/bin/clang -cc1 -internal-isystem /b/s/w/ir/k/recipe_cleanup/clangVieak_/llvm_build_dir/lib/clang/10.0.0/include -nostdsysteminc -emit-llvm -o - /b/s/w/ir/k/llvm-project/clang/test/CodeGen/alias.c | /b/s/w/ir/k/recipe_cleanup/clangVieak_/llvm_build_dir/bin/FileCheck -check-prefix=CHECKGLOBALS /b/s/w/ir/k/llvm-project/clang/test/CodeGen/alias.c
  --
  Exit Code: 2
  
  Command Output (stderr):
  --
  /b/s/w/ir/k/llvm-project/clang/test/CodeGen/alias.c:87:33: warning: alias will always resolve to test8_bar even if weak definition of test8_foo is overridden
  void test8_zed() __attribute__((alias("test8_foo")));
                                  ^
  /b/s/w/ir/k/llvm-project/clang/test/CodeGen/alias.c:90:37: warning: alias will not be in section 'test' but in the same section as the aliasee
  void test9_zed(void) __attribute__((section("test")));
                                      ^
  2 warnings generated.
  /b/s/w/ir/k/llvm-project/clang/test/CodeGen/alias.c:87:33: warning: alias will always resolve to test8_bar even if weak definition of test8_foo is overridden
  void test8_zed() __attribute__((alias("test8_foo")));
                                  ^
  /b/s/w/ir/k/llvm-project/clang/test/CodeGen/alias.c:90:37: warning: alias will not be in section 'test' but in the same section as the aliasee
  void test9_zed(void) __attribute__((section("test")));
                                      ^
  2 warnings generated.
  /b/s/w/ir/k/llvm-project/clang/test/CodeGen/alias.c:87:33: warning: alias will always resolve to test8_bar even if weak definition of test8_foo is overridden
  void test8_zed() __attribute__((alias("test8_foo")));
                                  ^
  /b/s/w/ir/k/llvm-project/clang/test/CodeGen/alias.c:90:37: warning: alias will not be in section 'test' but in the same section as the aliasee
  void test9_zed(void) __attribute__((section("test")));
                                      ^
  2 warnings generated.
  /b/s/w/ir/k/llvm-project/clang/test/CodeGen/alias.c:24:57: error: aliases are not supported on darwin
  extern const int __mod_usb_device_table __attribute__ ((alias("wacom_usb_ids")));
                                                          ^
  /b/s/w/ir/k/llvm-project/clang/test/CodeGen/alias.c:31:28: error: aliases are not supported on darwin
  extern int g1 __attribute((alias("g0")));
                             ^
  /b/s/w/ir/k/llvm-project/clang/test/CodeGen/alias.c:37:50: error: aliases are not supported on darwin
  extern __thread int __libc_errno __attribute__ ((alias ("TL_WITH_ALIAS")));
                                                   ^
  ... A bunch more like this
  
  --
  
  ********************
  Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
  Testing Time: 126.01s
  ********************
  Failing Tests (1):
      Clang :: CodeGen/alias.c

Could you take a look? Thanks.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66492/new/

https://reviews.llvm.org/D66492