[PATCH] D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467)

[Nick Desaulniers via Phabricator via cfe-commits]

nickdesaulniers added inline comments.


================
Comment at: clang/lib/Sema/SemaChecking.cpp:8101
+        // All further checking is done on the subexpression
+        Match = AT.matchesType(S.Context, ExprTy);
+        if (Match) {
----------------
Maybe leave the top level Match const and just create a new one?  It may be surprising if someone goes to reuse `Match` below not noticing that it may be modified here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66186/new/

https://reviews.llvm.org/D66186