[PATCH] D66122: [CodeGen] Emit dynamic initializers for static TLS vars in outlined scopes

Thu Aug 22 07:01:20 PDT 2019

Prince781 marked an inline comment as done.
Prince781 added a comment.

In D66122#1639947 <https://reviews.llvm.org/D66122#1639947>, @efriedma wrote:

> But given that, I think we should submit a core issue, and hold off on merging this until we hear back from the committee.

I agree here. There does appear to be some previous discussion on this matter, but the spec itself still doesn't contain any language addressing this issue. I will submit a core issue.

================
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:317
+          deps.insert(V);
+          auto V_Refs = enumerateVarInitDependencies(V);
+          deps.insert(V_Refs.begin(), V_Refs.end());
----------------
efriedma wrote:
> Do you need to recurse here?  It looks like the caller should handle that.
Oops, I think you might be right.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66122/new/

https://reviews.llvm.org/D66122