[PATCH] D66541: [clangd] Send highlighting diff beyond the end of the file.

[Haojian Wu via Phabricator via cfe-commits]

hokein marked an inline comment as done.
hokein added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp:625
+              testing::UnorderedElementsAre(
+                  testing::AllOf(LineNumber(3), EmptyHighlightings()),
+                  testing::AllOf(LineNumber(4), EmptyHighlightings())));
----------------
jvikstrom wrote:
> Maybe create the HighlightingLine objects for Line 3 and 4 and add them directly in the `UnorderedElementsAre` because then we don't have to create the matchers.
we prefer to use gtest matchers in the unittest as they are easier to understand, and provide better error messages (when the tests fail).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66541/new/

https://reviews.llvm.org/D66541