[PATCH] D66538: [AST] AST structural equivalence to work internally with pairs.

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 22 02:51:50 PDT 2019


martong added inline comments.


================
Comment at: clang/unittests/AST/StructuralEquivalenceTest.cpp:1323
+            NonEquivalentDecls.end());
+  EXPECT_EQ(NonEquivalentDecls.find(std::make_pair(y1, y2)),
+            NonEquivalentDecls.end());
----------------
This should be `EXPECT_NE` ! Because `void y(A*)` is not eq to `void y(B*)`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66538/new/

https://reviews.llvm.org/D66538





More information about the cfe-commits mailing list