[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

[Dávid Bolvanský via Phabricator via cfe-commits]

xbolva00 added a comment.

>> I think adding parens and casts are fairly well-understood to suppress warnings.

It should work here as well. #define ALPHA_OFFSET (3). Did anobody from Chromium try it?

>> They have varying levels of C++ proficiency

I consider things like hex decimals or parens to silence as a quite basic knowledge.

>> We have to be careful about which warnings we enable

I dont want off by default warning - useless. If there are still infinite macro concerns, I will revert just base patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66397/new/

https://reviews.llvm.org/D66397