[PATCH] D66564: [clang-tidy] new FPGA struct pack align check

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added a comment.

Please mention new module and check in Release Notes.



================
Comment at: clang-tidy/fpga/FPGATidyModule.cpp:5
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
----------------
License was changed this year. Same in other files.


================
Comment at: clang-tidy/fpga/StructPackAlignCheck.cpp:31
+  const auto *Struct = Result.Nodes.getNodeAs<RecordDecl>("struct");
+  const auto *StructDef = Struct->getDefinition();
+  
----------------
Please don't use auto when type is not spelled in same statement or not iterator.


================
Comment at: clang-tidy/fpga/StructPackAlignCheck.cpp:34
+  // If not a definition, do nothing
+  if (Struct != StructDef) return;
+  
----------------
Please run Clang-format.


================
Comment at: docs/clang-tidy/checks/fpga-struct-pack-align.rst:12
+
+Based on the "Altera SDK for OpenCL: Best Practices Guide".
+
----------------
Please add link to Altera documentation.


================
Comment at: docs/clang-tidy/index.rst:67
 ``clang-analyzer-``    Clang Static Analyzer checks.
+``fpga-``              Checks related to OpenCL programming for FPGAs..
 ``fuchsia-``           Checks related to Fuchsia coding conventions.
----------------
Please fix double dot.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66564/new/

https://reviews.llvm.org/D66564