[PATCH] D65835: [OpenMP] Permit map with DSA on combined directive
Joel E. Denny via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 21 15:44:24 PDT 2019
jdenny marked 4 inline comments as done.
jdenny added a comment.
Thanks.
================
Comment at: clang/lib/Sema/SemaExpr.cpp:17748
ObjCAvailabilityCheckExpr(Version, AtLoc, RParen, Context.BoolTy);
-}
\ No newline at end of file
+}
----------------
ABataev wrote:
> jdenny wrote:
> > ABataev wrote:
> > > Restore original code here
> > OK, I did. What's the reason for no newline at the end of the file?
> Changes not related to the patch, like formatting etc., better to commit in separate patches.
Ah.
================
Comment at: clang/lib/Sema/SemaExpr.cpp:17749
}
\ No newline at end of file
----------------
ABataev wrote:
> Still marked as changed code, better to restore it completely.
There's no change here. I checked the diff I uploaded to be sure.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65835/new/
https://reviews.llvm.org/D65835
More information about the cfe-commits
mailing list