[PATCH] D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category.

Manikishan Ghantasala via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 21 12:50:26 PDT 2019


Manikishan added a comment.

In D64695#1614386 <https://reviews.llvm.org/D64695#1614386>, @MyDeveloperDay wrote:

> Assuming this works and the other unit tests don't show issues then this LGTM. Please consider running this on your NetBSD code base before committing, if possible please also run on clang code based to ensure existing sorted headers aren't sorted unexpectedly.
>
> I do feel like there could be a documentation change missing really to explain to people how this really works and what if anything they have to change in their existing .clang-format files


I wIll update the documentation soon, within a day. And I will  also run it over both the clang, and netbsd code to make sure nothing goes wrong.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64695/new/

https://reviews.llvm.org/D64695





More information about the cfe-commits mailing list