[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

Wed Aug 21 11:14:00 PDT 2019

thakis added a comment.

In D66397#1635792 <https://reviews.llvm.org/D66397#1635792>, @aaron.ballman wrote:

> In D66397#1635745 <https://reviews.llvm.org/D66397#1635745>, @xbolva00 wrote:
>
> > I think it is too soon to jump and disable all macros. We still catch all motivating cases, it found bugs in Chromium.
>
>
> I think it's too soon to disable any macros. The workaround for Chromium is trivial and makes the code more clear.

I think I missed the workaround. I only saw the suggestion to write 0x2 instead of 2 which doesn't seem more clear at all to me. Was there another fix suggestion?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66397/new/

https://reviews.llvm.org/D66397