[PATCH] D63648: [Preprocessor] Honor absolute paths in diagnostics

[Alexandre Ganea via Phabricator via cfe-commits]

aganea added a comment.

In D63648#1593619 <https://reviews.llvm.org/D63648#1593619>, @thakis wrote:

> - Does fastbuild have something like distcc-pump?


Fastbuild works like plain distcc and unfortunately it does not have pump mode.

> - IIRC we used to use fdiagnostics-absolute-paths in Chromium but eventually stopped because someone figured out how to make MSVC's jump-to-diag work even with relative paths (?)

Let me know if you find out what was your solution ;) Otherwise we could absolutize paths in Fastbuild.

While I think we will go the relative paths route -  do you think the changes in this patch related to `--show-includes` and `note:` make sense? Could `-fdiagnostics-absolute-paths` affect `--show-includes` as well? I am just wondering. Otherwise I'll drop the patch.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63648/new/

https://reviews.llvm.org/D63648