[PATCH] D66473: [analyzer] Removed some dead code in BugReporter and related files

[Kristóf Umann via Phabricator via cfe-commits]

Szelethus added a comment.

No way the entire `NodeResolver` is dead code! I spent so much time trying to understand it! I mean, now that I think about it, we literally deep copy every `ExplodedNode`, so why would we need the mapping to the original, right?

Wow. Thank you so much for clearing this out.



================
Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:2263-2264
 /// A wrapper around an ExplodedGraph that contains a single path from the root
 /// to the error node, and a map that maps the nodes in this path to the ones in
 /// the original ExplodedGraph.
 class BugPathInfo {
----------------
Let's keep the comment up to date as well :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66473/new/

https://reviews.llvm.org/D66473