[PATCH] D66226: [clangd] Skip function bodies inside processed files while indexing

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added a comment.

This looks great, thanks!



================
Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:745
 
+bool SymbolCollector::shouldProcessFile(FileID FID) {
+  assert(ASTCtx);
----------------
we already have `shouldIndexFile` as an anonymous function inside this file, which performs a similar operation with a cache (since `FileFilter` performs symlink resolution and a disk read).

Could you make that one a member instead and use it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66226/new/

https://reviews.llvm.org/D66226