[PATCH] D66446: [clang][IFS] Adding new Interface Stubs format.

[Puyan Lotfi via Phabricator via cfe-commits]

plotfi created this revision.
plotfi added a reviewer: compnerd.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
plotfi marked an inline comment as done.
plotfi added inline comments.


================
Comment at: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:363
+      OS << "IfsVersion: 1.0\n";
+      OS << "Triple: " << T.str() << "\n";
+      OS << "Symbols:\n";
----------------
This is missing ObjectFileFormat: ELF


After posting llvm-ifs, I made some progress in hardening up how I think the format for Interface Stubs should look.
There are a number of things I think the TBE format was missing (no endianness, no info about the Object Format because it assumes ELF), so I have added those and broken off from being as similar to the TBE schema. I think in a subsequent commit I can drop the other formats.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D66446

Files:
  clang/include/clang/Frontend/FrontendActions.h
  clang/include/clang/Frontend/FrontendOptions.h
  clang/lib/Driver/ToolChains/Clang.cpp
  clang/lib/Frontend/CompilerInvocation.cpp
  clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp
  clang/lib/FrontendTool/ExecuteCompilerInvocation.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66446.216001.patch
Type: text/x-patch
Size: 6553 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190819/909090e3/attachment.bin>