[PATCH] D66423: [analyzer] CastValueChecker: Model isa(), isa_and_nonnull()

[Kristóf Umann via Phabricator via cfe-commits]

Szelethus added a comment.

Whoa, the test cases look AMAZING! I admit that I haven't read much of the other code just yet, but I like the results in any case.



================
Comment at: clang/test/Analysis/cast-value-notes.cpp:5-27
 namespace llvm {
 template <class X, class Y>
 const X *cast(Y Value);
 
 template <class X, class Y>
 const X *dyn_cast(Y *Value);
 template <class X, class Y>
----------------
Hmm, we may want to move these eventually to `clang/test/Inputs/`, since this isn't the only LLVM checker. Thought that said, I want to see the other LLVM checker gone, like, purged from the codebase for being the abomination that it is.

Feel free to leave these here for know, just thinking aloud :)


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66423/new/

https://reviews.llvm.org/D66423