[PATCH] D66067: Push lambda scope earlier when transforming lambda expression

Sun Aug 18 15:03:15 PDT 2019

comex marked an inline comment as done.
comex added inline comments.

================
Comment at: clang/test/SemaTemplate/default-arguments-cxx0x.cpp:1
-// RUN: %clang_cc1 -fsyntax-only -std=c++11 -verify %s
+// RUN: %clang_cc1 -fsyntax-only -std=c++14 -verify %s
 // expected-no-diagnostics
----------------
Mordante wrote:
> Wouldn't it be better to keep the original C++11 test and add a second `RUN:` for the C++14 test?
> Then guard the new test with `#if __cplusplus >= 201402L`
Perhaps, but most tests aren't run multiple times with different -std options, and I didn't see any reason this test in particular needed that.  Maybe it should just be renamed to default-arguments-cxx14.cpp.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66067/new/

https://reviews.llvm.org/D66067