[PATCH] D65287: [analyzer][CFG] Don't track the condition of asserts

Kristóf Umann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Aug 17 10:06:53 PDT 2019


Szelethus marked an inline comment as done.
Szelethus added inline comments.


================
Comment at: cfe/trunk/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1759
+    if (isa<BinaryOperator>(ElseCond)) {
+      assert(cast<BinaryOperator>(ElseCond)->isLogicalOp());
+      return isAssertlikeBlock(Else, Context);
----------------
Okay, this is stupid. Commited rL369195 to turn this into a condition, accompanied with a test case that would cause an assertion failure.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65287/new/

https://reviews.llvm.org/D65287





More information about the cfe-commits mailing list